Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect orientation lock settings from the app bundle and uses this information to refine how the bottom sheet width is calculated on iPhones in landscape mode. The main improvement is that the bottom sheet will only use 40% of the width in iPhone landscape if the orientation lock is either unlocked or set to landscape-only, ensuring better adaptation to app orientation constraints.
Orientation lock detection:
OrientationHelper.swiftwith thebundleOrientationLock()function, which reads the app's supported interface orientations from the bundle and determines if the orientation is portrait-only, landscape-only, or unlocked.Bottom sheet width calculation refinement:
BottomSheetView+Calculations.swiftto only apply the 40% width rule if the orientation lock is unlocked or landscape-only, improving compatibility with apps that restrict orientation.