Open
Conversation
Owner
|
Thanks Yutai! I'll get around back to this next week -- I don't think I can merge in the PR as-is since the notebook output hasn't been cleaned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/brax_minatar.ipynb imports a version of
LogEnvStateandLogWrapperfrom gymnax that does not supporttimesteplogging, so the notebook does not run successfully.This commit adds the newer definition of those two classes from
purejaxrl/wrappers.pyinto the notebook to make it run successfully.I only made this PR to raise awareness of the issue. I am not too familiar with the code base yet, so it's possible that I made a bunch of redundant imports.
Thank you for the wonderful blog post! To me, this is the "4 minute mile" equivalent of showing the cool possibilities of speeding up RL using jax :)