feat: Aligned Masking Model with Johnston (1988) and standardized configurations#89
Merged
lucianodato merged 7 commits intomainfrom Feb 15, 2026
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 77.29% 77.25% -0.04%
==========================================
Files 33 33
Lines 2911 3012 +101
Branches 640 666 +26
==========================================
+ Hits 2250 2327 +77
- Misses 345 364 +19
- Partials 316 321 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e critical bands into the spectral smoother.
…itialize` in `test_shared_utils.c`.
…ansient_detector_process` function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the
MaskingEstimatorstrictly with the Johnston (1988) psychoacoustic model while providing modern enhancements as optional toggles. It also centralizes all DSP parameters intoconfigurations.hand updates the repository's coding standards.Key Changes
MaskingVeto,TransientDetector, andMaskingEstimatorintosrc/shared/configurations.h.coding_standardsskill to mandate "No Magic Numbers in Core DSP".transient_detector_processcall inMaskingVeto.Verification Status
masking_estimator,masking_veto, andtransient_detectorare passing.