Skip to content

ci: Enable AVX optimizations for bundled libspecbleach#150

Open
lucianodato wants to merge 4 commits intomasterfrom
feature/libspecbleach-optimizations
Open

ci: Enable AVX optimizations for bundled libspecbleach#150
lucianodato wants to merge 4 commits intomasterfrom
feature/libspecbleach-optimizations

Conversation

@lucianodato
Copy link
Owner

@lucianodato lucianodato commented Mar 3, 2026

Enabling AVX optimizations to ensure SIMD instructions are correctly compiled for AMD64 architectures during CI builds.

Summary by CodeRabbit

  • Chores
    • Updated external library dependency to the latest version.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a757107 and c64ef18.

📒 Files selected for processing (1)
  • subprojects/libspecbleach.wrap
🚧 Files skipped from review as they are similar to previous changes (1)
  • subprojects/libspecbleach.wrap

📝 Walkthrough

Walkthrough

A dependency wrap file is updated to pin a newer git revision of the libspecbleach library. The change modifies only the revision hash reference without altering the wrap file's structure or configuration.

Changes

Cohort / File(s) Summary
Dependency Version Bump
subprojects/libspecbleach.wrap
Updated pinned git revision from 2f83af8... to 02028ae... for libspecbleach dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A hop, a skip, a revision so new,
The libspecbleach hash is bumped right on through!
From one commit blessed to another so fine,
Dependencies dancing—everything's in line! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions enabling AVX optimizations, but the actual change only bumps the git revision of the libspecbleach wrap file without explicit AVX-related changes. Clarify whether the AVX optimizations are enabled by the new revision itself, or if additional configuration changes are needed alongside this revision bump.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/libspecbleach-optimizations

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/build.yml:
- Line 42: The Meson invocation includes an unsupported subproject option
"-Dlibspecbleach:enable_avx=true" which can break builds; remove that option
from the Meson command lines (the occurrences of
"-Dlibspecbleach:enable_avx=true" in the workflow) or first confirm with
libspecbleach maintainers that the option exists, and if they add AVX support
add appropriate runtime CPU feature detection/dispatch (e.g.,
__builtin_cpu_supports or compiler multiversioning) in libspecbleach before
enabling it; update the workflow to omit "-Dlibspecbleach:enable_avx=true"
unless upstream confirms and runtime safeguards are implemented.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c48249 and 2a8c948.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant