ci: Enable AVX optimizations for bundled libspecbleach#150
ci: Enable AVX optimizations for bundled libspecbleach#150lucianodato wants to merge 4 commits intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA dependency wrap file is updated to pin a newer git revision of the libspecbleach library. The change modifies only the revision hash reference without altering the wrap file's structure or configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build.yml:
- Line 42: The Meson invocation includes an unsupported subproject option
"-Dlibspecbleach:enable_avx=true" which can break builds; remove that option
from the Meson command lines (the occurrences of
"-Dlibspecbleach:enable_avx=true" in the workflow) or first confirm with
libspecbleach maintainers that the option exists, and if they add AVX support
add appropriate runtime CPU feature detection/dispatch (e.g.,
__builtin_cpu_supports or compiler multiversioning) in libspecbleach before
enabling it; update the workflow to omit "-Dlibspecbleach:enable_avx=true"
unless upstream confirms and runtime safeguards are implemented.
Enabling AVX optimizations to ensure SIMD instructions are correctly compiled for AMD64 architectures during CI builds.
Summary by CodeRabbit