Refactor providers and harden tool/response handling#67
Open
Refactor providers and harden tool/response handling#67
Conversation
36e3cb8 to
c8aa26d
Compare
…n up client - Add comment on FunctionToolCall.r#type explaining why serde default is needed (tagged enum consumes the field during deserialization) - Replace misleading deserialization test with two focused tests: variant selection and serialize round-trip - Inline unnecessary messages_clone variable in generate_completion - Document partial-failure semantics on process_parallel_function_calls
c8aa26d to
4ba3f46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review fixes
FunctionToolCall.r#typeneeds a serdedefault(tagged enum consumes the field during deserialization, but it's required when serializing back as an API input item)messages_clonevariable ingenerate_completionprocess_parallel_function_callsValidation
Notes
-liconv); targeted unit/integration/examples suites above pass.