Skip to content

Fix canonical tag to resolve from Entry #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fetii1 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix canonical tag to resolve from Entry #47

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae0d5bf
fixed entries for canonical
fetii1 Aug 28, 2025
bf5637b
simplified logic
fetii1 Aug 28, 2025
1c5a4f3
tw description fix
fetii1 Aug 29, 2025
118ed8c
cleanup
fetii1 Aug 29, 2025
0895db9
fixed append/prepend
fetii1 Nov 21, 2025
01f409d
added nullsafe operator
fetii1 Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions export/app/Tags/LuckySeo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,8 @@ public function title()
$title = $this->context->get('seo_custom_meta_title');
}

if ($append) {
return "$title - $append";
}

if($prepend) {
return "$prepend - $title";
if ($append || $prepend) {
return ($prepend ? "$prepend - " : '') . "$title" . ($append ? " - $append" : '');
}

return $title;
Expand All @@ -51,7 +47,7 @@ public function description()
return $this->context->get('seo_custom_meta_description');
}

return null;
return null;
}

/**
Expand All @@ -61,7 +57,23 @@ public function description()
*/
public function canonical()
{
return $this->context->raw('seo_canonical') ? $this->context->get('seo_canonical') : $this->context->get('permalink');
$value = $this->context->get('seo_canonical');

$resolved = $value?->value();

if ($resolved instanceof \Statamic\Fieldtypes\Link\ArrayableLink) {
$entry = $resolved->value();

if ($entry instanceof \Statamic\Entries\Entry) {
return $entry->absoluteUrl();
}

if (is_string($entry)) {
return $entry;
}
}

return $this->context->get('permalink');
}

/**
Expand Down Expand Up @@ -128,7 +140,7 @@ public function twTitle()
*/
public function twDescription()
{
$desc_config = $this->context->raw('seo_og_description');
$desc_config = $this->context->raw('seo_tw_description');

if ($desc_config === 'meta') {
return $this->description();
Expand All @@ -140,7 +152,7 @@ public function twDescription()
}

if($desc_config === 'custom') {
return $this->context->get('seo_custom_og_desc');
return $this->context->get('seo_custom_tw_desc');
}

return null;
Expand Down