Adding for_collection to the BaseSerializer.#884
Merged
jwoertink merged 3 commits intoluckyframework:mainfrom Jun 27, 2025
Merged
Adding for_collection to the BaseSerializer.#884jwoertink merged 3 commits intoluckyframework:mainfrom
jwoertink merged 3 commits intoluckyframework:mainfrom
Conversation
This for_collection override takes a Lucky::Paginator argument as an option and changes the output to have extra pagination data added in.
Member
|
Nice! Looks good. It's just missing the part that actually adds this to the generated app. lucky_cli/src/lucky_cli/src_template.cr Lines 214 to 218 in ccaa571 |
Contributor
Author
|
Oops. That would make sense wouldn't it. lol |
Member
|
For this, you may need to run |
jwoertink
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #866
This for_collection override takes a Lucky::Paginator argument as an option and changes the output to have extra pagination data added in.