fix: omit error-check for 201 responses in async_call_api#391
Merged
ludeeus merged 4 commits intoludeeus:mainfrom Apr 16, 2025
Merged
fix: omit error-check for 201 responses in async_call_api#391ludeeus merged 4 commits intoludeeus:mainfrom
ludeeus merged 4 commits intoludeeus:mainfrom
Conversation
ludeeus
reviewed
Feb 19, 2025
mbrisx
force-pushed
the
fix/omit-201-error-check
branch
from
7dacade to
80e18cb
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Skip error-checking for responses with a 201 status code in async_call_api, preventing false error raises for successful REST operations.
mbrisx
force-pushed
the
fix/omit-201-error-check
branch
from
80e18cb to
3a2c007
Compare
📝 WalkthroughWalkthroughThe error handling logic in the API client was updated to consider the HTTP status code when processing responses containing a "message" field. Specifically, if the status code is 201 (Created), the client will no longer raise a Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GitHubAPI
Client->>GitHubAPI: Send API request
GitHubAPI-->>Client: Respond with status code and data
alt Response contains "message"
alt Status code is 201
Client-->>Client: Do not raise exception
else Status code is not 201
Client-->>Client: Raise GitHubException
end
else No "message" in response
Client-->>Client: Continue normal processing
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ludeeus
reviewed
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR modifies the error-handling logic in the
async_call_apimethod for REST API calls. GitHub sometimes returns a 201 (Created) status code along with a "message" field as part of a successful response. Since a 201 response always indicates success, this change omits the error-check for such responses, preventing false error raises. This fix applies to all REST API endpoints where a 201 status is expected.Type of change
Additional information
Checklist
make lint)