Remove logging for missing keys in GitHubDataModelBase#470
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes debug logging functionality that warned developers about unhandled keys in GitHub API responses. The change eliminates the IGNORE_KEYS constant and the associated elif branch that logged missing keys when _log_missing was enabled.
- Removes the
IGNORE_KEYStuple constant containing commonly ignored GitHub API fields - Removes the conditional logging block that logged debug messages for keys not present as attributes in model classes
Comments suppressed due to low confidence (1)
aiogithubapi/models/base.py:26
- The
_log_missingclass attribute is now unused after removing the debug logging logic. It should be removed fromGitHubDataModelBase(line 26) and fromGitHubReactionModelinaiogithubapi/models/reaction.py(line 11) where it's set toFalse.
_log_missing: bool = True
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This does not really matter and it is quite spammy.
Type of change
Checklist
scripts/test)scripts/lint)