Skip to content

Remove logging for missing keys in GitHubDataModelBase#470

Merged
ludeeus merged 1 commit intomainfrom
removelogging
Nov 9, 2025
Merged

Remove logging for missing keys in GitHubDataModelBase#470
ludeeus merged 1 commit intomainfrom
removelogging

Conversation

@ludeeus
Copy link
Copy Markdown
Owner

@ludeeus ludeeus commented Nov 9, 2025

Description

This does not really matter and it is quite spammy.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements

Checklist

  • Tests pass locally (scripts/test)
  • Code has been formatted (scripts/lint)
  • Tests added for new functionality (if applicable)

Copilot AI review requested due to automatic review settings November 9, 2025 07:02
@ludeeus ludeeus added the enhancement Enhancement to existing functionality label Nov 9, 2025
@ludeeus ludeeus merged commit f5d2cf6 into main Nov 9, 2025
11 checks passed
@ludeeus ludeeus deleted the removelogging branch November 9, 2025 07:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes debug logging functionality that warned developers about unhandled keys in GitHub API responses. The change eliminates the IGNORE_KEYS constant and the associated elif branch that logged missing keys when _log_missing was enabled.

  • Removes the IGNORE_KEYS tuple constant containing commonly ignored GitHub API fields
  • Removes the conditional logging block that logged debug messages for keys not present as attributes in model classes
Comments suppressed due to low confidence (1)

aiogithubapi/models/base.py:26

  • The _log_missing class attribute is now unused after removing the debug logging logic. It should be removed from GitHubDataModelBase (line 26) and from GitHubReactionModel in aiogithubapi/models/reaction.py (line 11) where it's set to False.
    _log_missing: bool = True

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants