Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GitHub's notifications API by introducing a new notifications namespace. The implementation follows the established patterns in the codebase for namespaces and models.
Key changes:
- Added
GitHubNotificationModelwith nested_Subjectmodel to represent notification data - Implemented
GitHubNotificationsNamespacewith alist()method supporting filtering parameters - Integrated the notifications namespace into the main
GitHubAPI class
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
aiogithubapi/models/notification.py |
Defines notification data models with fields for id, repository, subject, reason, and read status |
aiogithubapi/namespaces/notifications.py |
Implements the notifications namespace with list method supporting pagination and filtering |
aiogithubapi/github.py |
Integrates notifications namespace into the main API class |
aiogithubapi/__init__.py |
Exports GitHubNotificationModel for public API access |
tests/namespaces/test_notifications.py |
Adds test coverage for the list notifications endpoint |
tests/fixtures/notifications.json |
Provides mock response data for notifications tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
8 tasks
…ns namespace (#478) * Initial plan * Apply review feedback: use consistent type annotations in notifications namespace Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com> * Update aiogithubapi/namespaces/notifications.py * Update aiogithubapi/namespaces/notifications.py --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com> Co-authored-by: Joakim Sørensen <joasoe@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds notification namespace to list notifications.
Type of change
Checklist
scripts/test)scripts/lint)