Conversation
Signed-off-by: Luis Garcia <git@luigi311.com>
Signed-off-by: Luis Garcia <git@luigi311.com>
luigi311
force-pushed
the
fix_reading_local_downloads
branch
from
186d33d to
f6393aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#70 worked when it came to fetching remote images but failed when trying to read from downloaded images. This redesigns it so only fetch_image_from_url is modified with the extension get image bytes calls. This does require the source_id fed in and required the web client calls to be modified to include it as a parameter. Removed referer parameters as those arent needed anymore as the extensions should all be handling referer and user agents.