Add support for watching elements other than window#131
Open
j0xhn wants to merge 2 commits intoluis-almeida:masterfrom
Open
Add support for watching elements other than window#131j0xhn wants to merge 2 commits intoluis-almeida:masterfrom
j0xhn wants to merge 2 commits intoluis-almeida:masterfrom
Conversation
added 2 commits
December 15, 2016 12:59
Adds support for items located off the side of the screen to the right, as well as watching for a parent to scroll incase they've locked the background in the use case of a modal or side-drawer element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I loved how small this code is, but needed just a little bit more functionality of detecting other elements that are off to the SIDE of the screen, not just below the fold. Also allows to watch scrolling of a parent or other element (incase images are nested) incase the images are in a modal or side-drawer (that was my use case) and you've frozen the body to not allow any scrolling. This will allow for that. Didn't know if you guys have purposely left it out, but I thought I'd share with you incase you wanted to add it to your code. Doesn't add much complexity, but does increase usability :)