Ability to specify a different scroll container than window#65
Open
christianrondeau wants to merge 3 commits intoluis-almeida:masterfrom
Open
Ability to specify a different scroll container than window#65christianrondeau wants to merge 3 commits intoluis-almeida:masterfrom
christianrondeau wants to merge 3 commits intoluis-almeida:masterfrom
Conversation
…ify a url rather than reading data-src
|
@christianrondeau this is interesting, i have recently tried to use Unveil with Iscroll. I am trying out v2, it had some nice features :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to use unveil in a scrollable div rather than a scrollable window. Here are the changes I had to do to achieve this.
Note that it would have been better to provide an options object with
$.extendfor parameters, but this required the least amount of changes, and didn't break existing implementations.