Skip to content

Refactor network.send_icmp to use deafult OS ping size #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor network.send_icmp to use deafult OS ping size #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29989cf
Refactor network.send_icmp to use deafult OS ping size
Oct 24, 2018
924869a
Refactor network.send_icmp to use deafult OS ping size
Oct 24, 2018
a2b9e38
Merge branch 'refactor-send-icmp_master' of github.com:MosheSheena/py…
Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rrmngmnt/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def delete_ifcfg_file(self, nic, ifcfg_path=IFCFG_PATH):
return False
return True

def send_icmp(self, dst, count="5", size="1500", extra_args=None):
def send_icmp(self, dst, count="5", size=None, extra_args=None):
"""
Send ICMP to destination IP/FQDN

Expand All @@ -500,9 +500,9 @@ def send_icmp(self, dst, count="5", size="1500", extra_args=None):
:return: True/False
:rtype: bool
"""
cmd = ["ping", dst, "-c", count, "-s", size]
if size != "1500":
cmd.extend(["-M", "do"])
cmd = ["ping", dst, "-c", count]
if size is not None:
cmd.extend(["-s", str(size), "-M", "do"])
if extra_args is not None:
for ar in extra_args.split():
cmd.extend(ar.split())
Expand Down