Recurse on directories specified on the command line#38
Open
ichernev wants to merge 1 commit intolukaszkorecki:masterfrom
Open
Recurse on directories specified on the command line#38ichernev wants to merge 1 commit intolukaszkorecki:masterfrom
ichernev wants to merge 1 commit intolukaszkorecki:masterfrom
Conversation
Owner
|
@ichernev Hi! Thanks for the pull request! To set yourself up you will need:
to run tests simply execute: I will update the readme to explain how to set the project up. So far I can see your PR didn't break anything thanks to Travis CI testing all branches :-) |
Collaborator
|
While it appears that no tests were broken, I would like to see new tests showing that it works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
-Ronly recurses on the current directory. Sometimes its desirable to recurse on a sub-directory.So in this patch I try to recurse on all given directories.
I'm not sure how to run the tests / install the env so you have to check if that still works :) (or let me know how to set it up).