Skip to content

Conversation

jefflembeck
Copy link

@jefflembeck jefflembeck commented May 20, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

This addresses number #794.

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

Potential Problems With The Approach

There is probably way too much here. I cargo culted a ton of things over from 3.0.0. I also made some changes to how certain types extend others.

Test plan

Broke out tests and fixtures strictly for 3.1. Happy to make changes to that, but wanted something we could start talking out earlier rather than later.

This involved breaking 2 and 3 out a little to better mirror the
differences in the specs
@jefflembeck jefflembeck changed the title Openapi 3dot1 Open API 3.1.0 support May 20, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there jefflembeck 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@jefflembeck
Copy link
Author

My real issue I wanted to get to the bottom of was getting variadic tuples in. But the differences in prefixItems and items and what is possible for 3.1.0 vs 3.0.0 made me shoot for the moon a little.

@bioc-druzgami
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants