feat: add support for union/enum types for @FormField() #1778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
stsvilik
force-pushed
the
form-field-enum-types
branch
from
e4339a8 to
07c67b5
Compare
|
@WoH could you please review? 🙏 |
|
@lukeautry maybe you can review? |
|
Hi, the code change sounds reasonable, but can you add a test to demo the change? |
|
@WoH I found where to add tests and updated PR :) |
stsvilik
force-pushed
the
form-field-enum-types
branch
from
f2071dd to
b0b7c54
Compare
stsvilik
commented
Sep 10, 2025
| @Get('ParameterHeaderStringType') | ||
| public async headerStringType(@Header() header: string): Promise<void> { | ||
| // | ||
| @Get('FormData') |
There was a problem hiding this comment.
Renamed it from FormDataStringType since now it supports many types.
stsvilik
commented
Sep 10, 2025
| // | ||
| @Get('FormData') | ||
| public async formData(@FormField() data: string, @FormField() indexes: EnumNumberValue, @FormField() gender: Gender): Promise<FormTestModel> { | ||
| return Promise.resolve<FormTestModel>({ |
There was a problem hiding this comment.
Example of string and two enum types
stsvilik
force-pushed
the
form-field-enum-types
branch
from
b0b7c54 to
caee748
Compare
stsvilik
force-pushed
the
form-field-enum-types
branch
from
caee748 to
2a42d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
closes #1777If this is a new feature submission:
Potential Problems With The Approach
Test plan