Refactor: Replace validator.js dependency from @tsoa/cli #1830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Motivation: we use
@tsoa/cliin some of our AWS Lambdas and it happens to import the entirety ofvalidator.jswhich is 130kB of about just anything, where it's just used for ISO8601 checks in@tsoa/cli.130kB of unused code is bad in itself – but in general bundling that much extra code makes cold starts in Node.JS lambdas worse.
Potential Problems With The Approach
This only replaces
validator.jsdependency in@tsoa/cli, not in@tsoa/runtime.Other than that,
validator.jsis a CJS package and it's not tree-shakeable no matter how you import it. Once you import it, you get everything.Test plan
Unit tested the custom function.