Fix 404 error when calling with full URL#6
Open
ewanharris wants to merge 1 commit intolukeed:masterfrom
Open
Conversation
Author
|
npm@6 dropped support for Node 4 so npm install@latest will fail there. Node 4 is now EOL so 🤷♂️. Let me know if you'd like me to drop Node 4 from travis/appveyor and add 8/10, or fix the Appveyor build to not install latest |
Author
|
@lukeed (sorry for the ping 😬 ) any thoughts on the above? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a 404 when calling
gittar.fetch('https://github.com/lukeed/mri').then(console.log);where the URL would be constructed incorrectly (https://github.com///github.com/lukeed/mri/archive/master.tar.gz) due to the hostname already existing