Skip to content

fix(history): 修复“全部会话”中浏览较老历史并点击详情后未成功跳转 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lulu-sk merged 1 commit into from
Mar 12, 2026
Merged

fix(history): 修复“全部会话”中浏览较老历史并点击详情后未成功跳转 #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 37 additions & 21 deletions web/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2944,7 +2944,9 @@ export default function CodexFlowManagerUI() {
canonicalizePath(project.wslPath || ""),
canonicalizePath(project.winPath || ""),
].filter(Boolean))));
const baseCacheKey = effectiveScope === "all_sessions" ? "all_sessions" : projectIds.join("|");
const baseCacheKey = effectiveScope === "all_sessions"
? "all_sessions"
: `${projectIds.join("|")}::${projectNeedles.join("|")}`;
return {
requestedScope,
effectiveScope,
Expand Down Expand Up @@ -4484,7 +4486,8 @@ export default function CodexFlowManagerUI() {
let cancelled = false;

(async () => {
const descriptor = historyScopeDescriptor;
// 中文说明：通过 ref 读取最新范围描述，避免“全部会话”下仅同步左侧项目时误触发整页历史重载。
const descriptor = historyScopeDescriptorRef.current;
if (!descriptor.primaryProject && descriptor.effectiveScope !== "all_sessions") {
setHistorySessions([]);
applyHistoryPagination({ hasMore: false, nextOffset: 0 });
Expand Down Expand Up @@ -4533,26 +4536,39 @@ export default function CodexFlowManagerUI() {
try {
const mapped = await fetchHistoryPage(descriptor, 0, HISTORY_PAGE_INITIAL_LIMIT);
if (cancelled) return;
const hasMore = mapped.length >= HISTORY_PAGE_INITIAL_LIMIT;
const nextOffset = mapped.length;
applyHistoryPagination({ hasMore, nextOffset });
setHistorySessions(mapped as any);
setHistoryCache(projectKey, { sessions: mapped, hasMore, nextOffset });
const fetchedHasMore = mapped.length >= HISTORY_PAGE_INITIAL_LIMIT;
const fetchedNextOffset = mapped.length;
const shouldPreservePagedCache = hasCache && cachedSessions.length > mapped.length;
const nextSessions = shouldPreservePagedCache
? mergeHistorySessions(cachedSessions, mapped)
: mapped;
const nextHasMore = shouldPreservePagedCache
? (!!cached?.hasMore || fetchedHasMore)
: fetchedHasMore;
const nextOffset = shouldPreservePagedCache
? Math.max(
Math.max(0, Number(cached?.nextOffset || cachedSessions.length)),
fetchedNextOffset,
)
: fetchedNextOffset;
applyHistoryPagination({ hasMore: nextHasMore, nextOffset });
setHistorySessions(nextSessions as any);
setHistoryCache(projectKey, { sessions: nextSessions, hasMore: nextHasMore, nextOffset });
// 校验并修正当前选择，避免缓存残留导致的空白详情
if (!skipAuto) {
const ids = new Set(mapped.map((x) => x.id));
const nowRef = new Date();
const keyOf = (item?: HistorySession) => historyTimelineGroupKey(item, nowRef);
const dirs = new Set(mapped.map((x) => keyOf(x)));
const needResetId = !selectedHistoryId || !ids.has(selectedHistoryId);
const needResetDir = !selectedHistoryDir || !dirs.has(selectedHistoryDir);
if ((needResetId || needResetDir) && mapped.length > 0) {
const firstKey = keyOf(mapped[0]);
// 仅优化默认 UI：展开最新分组，不自动选择会话，也不切换到详情
setSelectedHistoryDir(null);
setSelectedHistoryId(null);
setExpandedGroups({ [firstKey]: true });
}
const ids = new Set(nextSessions.map((x) => x.id));
const nowRef = new Date();
const keyOf = (item?: HistorySession) => historyTimelineGroupKey(item, nowRef);
const dirs = new Set(nextSessions.map((x) => keyOf(x)));
const needResetId = !selectedHistoryId || !ids.has(selectedHistoryId);
const needResetDir = !selectedHistoryDir || !dirs.has(selectedHistoryDir);
if ((needResetId || needResetDir) && nextSessions.length > 0) {
const firstKey = keyOf(nextSessions[0]);
// 仅优化默认 UI：展开最新分组，不自动选择会话，也不切换到详情
setSelectedHistoryDir(null);
setSelectedHistoryId(null);
setExpandedGroups({ [firstKey]: true });
}
}
// 如果抑制了自动选择，需要在处理完加载后重置抑制标志
if (skipAuto) suppressAutoSelectRef.current = false;
Expand All @@ -4566,7 +4582,7 @@ export default function CodexFlowManagerUI() {
return () => {
cancelled = true;
};
}, [historyScopeDescriptor, historyInvalidateNonce, getHistoryCache, fetchHistoryPage, HISTORY_PAGE_INITIAL_LIMIT, applyHistoryPagination, setHistoryCache]);
}, [historyScopeDescriptor.cacheKey, historyScopeDescriptor.effectiveScope, historyInvalidateNonce, getHistoryCache, fetchHistoryPage, HISTORY_PAGE_INITIAL_LIMIT, applyHistoryPagination, mergeHistorySessions, setHistoryCache]);

// 订阅索引器事件：新增/更新/删除时，若属于当前历史范围则立即更新 UI
useEffect(() => {
Expand Down
Loading