Merged
Conversation
roussel-ryan
approved these changes
Feb 20, 2026
Collaborator
roussel-ryan
left a comment
There was a problem hiding this comment.
This looks good to me, @pluflou can also review. One thing to consider is that soon^(TM) we will add serialization / deserialization logic to the LUMEModel base class, which should handle a lot of this logic, so be prepared to move a lot of this to lume-base when the time is right
pluflou
approved these changes
Feb 20, 2026
Collaborator
|
Looks good to me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds full serialization and deserialization capabilities to the LUMETorchModel wrapper class, enabling models to be saved to and loaded from YAML configuration files.