Fix database connection error when using JsonGameSerializer#457
Merged
lare96 merged 1 commit intoluna-rs:masterfrom Mar 1, 2026
Merged
Conversation
(cherry picked from commit 25b239a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This small change fixes an error caused by trying to connect to the database in the World constructor, regardless of which serializer is configured. When using the json serializer, no database will be available, but the connection pool will be initialized anyway, causing the error. This patch checks if the json serializer is used, and initializes the connection pool to null if it is. This has no side effects, as the only class that uses this connection pool (besides the sql serializer) is BotRepository, and it correctly chooses between local storage and the database, depending on the serializer used.
Pull Request type
Checklist
Further comments
None.