Add manpage#704
Open
linuxmaniac wants to merge 1 commit intolunarmodules:masterfrom
Open
Conversation
From: Nilesh Patra <npatra974@gmail.com> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978760
Member
|
since the page mentions it is generated, should we add the generation logic instead of the file itself? |
Member
Yes. Lets add the code to regenerate the man page to the repo and make actually generating it part of the (automated) release process. |
alerque
requested changes
Oct 22, 2024
Member
alerque
left a comment
alerque
left a comment
There was a problem hiding this comment.
As noted before in comments but not reflected in GH's review system, this is a great contribution we'd love to have but if possible we'd actually like to make the generation command part of the project, not the final artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: Nilesh Patra npatra974@gmail.com
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978760
fix #696