Open
Conversation
Removed `DESTDIR` which did not appear to be defined, moved` ldoc.lua` to the `ldoc` directory to avoid encumbering the share directory, added proper retrieval of Lua version to get proper `LUA_SHAREDIR` directory. Additionally, the file should be renamed as `Makefile`. My apologies if I just missed something and this change proposal is irrelevant.
alerque
requested changes
Sep 29, 2020
Member
There was a problem hiding this comment.
Thanks for taking the time to contribute.
Some of this is okay, some is not.
- DESTDIR needs to come back, that can and often is defined outside of the makefile as part of distro packaging commands, e.g.
make install DESTDIR=/tmp/package/path. You can't remove that or most distros won't be able to build packages! - The filename is okay, both capitalized and not are valid.
- You can't assume directories exist. There are many different kinds of installs and not all of them look like you expect. Building packages in a
chrootis one place this may be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
DESTDIRwhich did not appear to be defined, movedldoc.luato theldocdirectory (on install only) to avoid encumbering the share directory, added proper retrieval of Lua version to get properLUA_SHAREDIR, made variables evaluations, immediate (=vs:=), removed redundant creation of the share directory (it’s already there if Lua is properly installed, which is implied). Additionally, the file should be renamed asMakefile.My apologies if I just missed something and this change proposal is irrelevant.