Fix weight-based shipping rate breakpoints evaluation#2382
Open
Huncsuga wants to merge 5 commits intolunarphp:1.xfrom
Open
Fix weight-based shipping rate breakpoints evaluation#2382Huncsuga wants to merge 5 commits intolunarphp:1.xfrom
Huncsuga wants to merge 5 commits intolunarphp:1.xfrom
Conversation
Sync 05.10.2025
Sync 14.12.2025
…convert cart lines weight to Kg
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where weight-based shipping rate breakpoints were evaluated incorrectly due to inconsistent weight unit handling. The fix ensures cart weights and pricing tier thresholds are normalized to kilograms before comparison, allowing weight-based shipping tiers to apply correctly.
Key Changes:
- Normalized all weight calculations to kilograms using the Converter facade
- Removed incorrect scaling factor (×100) when saving and loading weight-based pricing breakpoints
- Added UI helper text and suffix to clarify that weight thresholds should be entered in kg
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/table-rate-shipping/src/Drivers/ShippingMethods/ShipBy.php | Converts product weights to kg before calculating total cart weight |
| packages/table-rate-shipping/src/Filament/Resources/ShippingZoneResource/Pages/ManageShippingRates.php | Removes ×100 scaling for weight values and adds kg suffix/helper text to form field |
| packages/table-rate-shipping/resources/lang/en/relationmanagers.php | Adds English helper text indicating weight should be entered in kg |
| packages/table-rate-shipping/resources/lang/ro/relationmanagers.php | Adds Romanian helper text indicating weight should be entered in kg |
| packages/table-rate-shipping/resources/lang/hu/relationmanagers.php | Adds Hungarian helper text indicating weight should be entered in kg |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/table-rate-shipping/src/Drivers/ShippingMethods/ShipBy.php
Outdated
Show resolved
Hide resolved
packages/table-rate-shipping/src/Drivers/ShippingMethods/ShipBy.php
Outdated
Show resolved
Hide resolved
...able-rate-shipping/src/Filament/Resources/ShippingZoneResource/Pages/ManageShippingRates.php
Outdated
Show resolved
Hide resolved
… min_quantity casting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type
What was changed
Expected Outcome
How to test