Skip to content

Move cleanup actor to lunagraph. #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2024
Merged

Move cleanup actor to lunagraph. #73

merged 3 commits into from
Sep 11, 2024

Conversation

jdijt
Copy link
Contributor

@jdijt jdijt commented Sep 11, 2024

Bit of a mess in the service.
But it works, as in, I tested it locally with the delete call commented out.

@jdijt jdijt requested a review from wjglerum as a code owner September 11, 2024 14:21
wjglerum
wjglerum reviewed Sep 11, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jdijt jdijt enabled auto-merge (squash) September 11, 2024 14:28
wjglerum
wjglerum approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@wjglerum wjglerum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jdijt jdijt merged commit d6ef548 into main Sep 11, 2024
4 checks passed
@jdijt jdijt deleted the fix-cleanup-job branch September 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjglerum wjglerum wjglerum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdijt @wjglerum