fix(process): exec not reading until child exits#353
Merged
filiptibell merged 2 commits intolune-org:mainfrom Sep 14, 2025
Merged
fix(process): exec not reading until child exits#353filiptibell merged 2 commits intolune-org:mainfrom
filiptibell merged 2 commits intolune-org:mainfrom
Conversation
Fixes a bug where `process.exec` does not begin reading until the child process exits. This causes processes that write a lot of data to stdout to be unable to write data once the pipe buffer has filled up, causing them to hang.
filiptibell
approved these changes
Sep 14, 2025
Collaborator
|
Great analysis and fix, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
process.execdoes not begin reading until the child process exits. This causes processes that write a lot of data to stdout to be unable to write data once the pipe buffer has filled up, causing them to hang.