fix(process): readToEnd slow for large output#354
Merged
filiptibell merged 1 commit intolune-org:mainfrom Sep 14, 2025
Merged
Conversation
Fixes `readToEnd` on a child process created by `process.create` taking a very long time to complete when the process outputs a large amount of data. This is achieved by using `io::copy` instead of the `read_to_end` method on readers.
filiptibell
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
readToEndon a child process created byprocess.createtaking a very long time (reportedly up to 15 minutes!) to complete when the process outputs a large amount of data. This change reduces it to be less than 1s in most cases.This is achieved by using
io::copyinstead of theread_to_endmethod on readers.