Skip to content

Update to latest rbx-dom crates#358

Merged
filiptibell merged 6 commits intolune-org:mainfrom
kennethloeffler:update-to-latest-rbx-dom-crates
Oct 14, 2025
Merged

Update to latest rbx-dom crates#358
filiptibell merged 6 commits intolune-org:mainfrom
kennethloeffler:update-to-latest-rbx-dom-crates

Conversation

@kennethloeffler
Copy link
Contributor

This PR updates the lune-roblox crate to use the latest batch of releases from rbx-dom. There were some breaking changes in rbx_types and rbx_reflection_database, which are summarized here and here.

@kennethloeffler
Copy link
Contributor Author

kennethloeffler commented Oct 12, 2025

It looks like this reflection database contains an empty enum AudioCaptureMode, causing the roblox_reflection_enums test to fail with Enum items map must not be empty.

I've verified that it is also empty in an API dump directly from Roblox Studio, so not entirely sure what to do there...

Also not sure why the net_tcp_basic and net_tcp_tls tests have begun failing, I don't believe any of these changes should have affected those systems.

Copy link
Collaborator

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting this sorted! I think we can probably skip that specific empty enum in the test, for now.. and for the net tcp tests breaking - it seems like example.com changed their page structure somewhat, and that this is why those are suddenly failing. Nothing you need to worry about, I can fix those tests up before making the release.

@kennethloeffler
Copy link
Contributor Author

Suggestion: use a local web server that Lune controls or a site like httpbin.org for the net tests. I see that example.com has a disclaimer to "Avoid use in operations"!

@filiptibell filiptibell merged commit f15a939 into lune-org:main Oct 14, 2025
2 of 8 checks passed
@filiptibell
Copy link
Collaborator

Suggestion: use a local web server that Lune controls or a site like httpbin.org for the net tests. I see that example.com has a disclaimer to "Avoid use in operations"!

It seems like this specific disclaimer was added some time this month, at the same time as the page structure was changed and broke our test 🙃 but yeah, we should probably use something a bit more robust. The other net tests already do, I'm not sure why this one doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants