Update to latest rbx-dom crates#358
Conversation
|
It looks like this reflection database contains an empty enum I've verified that it is also empty in an API dump directly from Roblox Studio, so not entirely sure what to do there... Also not sure why the |
filiptibell
left a comment
There was a problem hiding this comment.
Thank you for getting this sorted! I think we can probably skip that specific empty enum in the test, for now.. and for the net tcp tests breaking - it seems like example.com changed their page structure somewhat, and that this is why those are suddenly failing. Nothing you need to worry about, I can fix those tests up before making the release.
|
Suggestion: use a local web server that Lune controls or a site like httpbin.org for the net tests. I see that example.com has a disclaimer to "Avoid use in operations"! |
It seems like this specific disclaimer was added some time this month, at the same time as the page structure was changed and broke our test 🙃 but yeah, we should probably use something a bit more robust. The other |
This PR updates the lune-roblox crate to use the latest batch of releases from rbx-dom. There were some breaking changes in rbx_types and rbx_reflection_database, which are summarized here and here.