Merged
Conversation
yoshi-monster
commented
Dec 15, 2025
| case "autocomplete": | ||
| if (config.on_form_populate instanceof Some) { | ||
| this.dispatch(config.on_form_autofill[0](state)); | ||
| if (Option$isSome(config.on_form_autofill)) { |
Contributor
Author
There was a problem hiding this comment.
Looks like this is a typo in the current version?
yoshi-monster
commented
Dec 15, 2025
we do not migrate field names to accessors yet except for built-in types defined in the prelude. We depend on the data representation to send values across the wire, so until we solve that there's not much reason to try to migrate at all.
yoshi-monster
force-pushed
the
migrate-ffi
branch
from
c437f3a to
e514be8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move constructors and
instanceofchecks that do not use ourkind- system to the new official FFI interface.I didn't migrate field names to the accessor functions yet EXCEPT for built-in types defined in the prelude. I expect them to change as Result is one of the motivations for these changes in the first place, and the list accessors have suspiciously different names from the fields.
We depend on the data representation / field names to send values across the wire, so until we solve that there's not much reason to try to migrate those.