Update VNet Tag type to uint32 and add max VNet Tag test case#244
Merged
luthermonson merged 1 commit intoluthermonson:mainfrom Feb 18, 2026
Merged
Conversation
Owner
|
nice catch |
luthermonson
approved these changes
Feb 18, 2026
yusing
pushed a commit
to yusing/go-proxmox
that referenced
this pull request
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag values for VNets can be in the range
1 - 16777215. They were previously stored in auint16which has as max value of65535. This caused an error when runningcluster.SDNVNet(ctx, "maxTagVnet")on a VNet with a tag value > 65535:json: cannot unmarshal number 16777215 into Go struct field VNet.tag of type uint16.This pull request changes the VNet Tag value to a
uint32which has a max value of4294967295and can hold any possible VNet tag value, and adds a test for a VNet with a tag value of16777215to catch any regression.Documentation: https://pve.proxmox.com/pve-docs/api-viewer/#/cluster/sdn/vnets/{vnet}