test-metrics: Don't rely on hrtime busy loop #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've observed this test getting stuck in the 32-bit Windows CI, presumably because the value happens to be just about at the limit of i32 which is the integer type of LuaJIT when targeting x86-windows (ptrdiff_t). This updated test is basically a port of the libuv test `metrics_idle_time_zero` in `test-metrics.c`. A side benefit is that there's no arbitrary 1 second wait anymore.
zhaozg
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed this test getting stuck in the 32-bit Windows CI (example one, example two), presumably because the
hrtimevalue happens to be just about at the limit of i32 which is the integer type of LuaJIT when targeting x86-windows (ptrdiff_t), or other such weirdness.This updated test is basically a port of the libuv test
metrics_idle_time_zerointest-metrics.c.A side benefit is that there's no arbitrary 1 second wait anymore.