mark bundle files as "files", use luaL_traceback#305
Merged
SinisterRectus merged 2 commits intoluvit:masterfrom Oct 4, 2025
Merged
mark bundle files as "files", use luaL_traceback#305SinisterRectus merged 2 commits intoluvit:masterfrom
SinisterRectus merged 2 commits intoluvit:masterfrom
Conversation
Member
Author
|
The 2 macos failures seem to be a luajit bug also present in master and are unrelated to the applied changes. |
Contributor
|
What's the difference between |
Member
Author
|
The workaround of going through
|
squeek502
approved these changes
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes here:
Prepends
@to the chunk name of bundled files so that the shortsrc name becomesbundle:fileinstead of[string "bundle:file"]in error messages. This is mostly just a convenience thing because the[string ""]just clutters the output on error.Luvi now uses
luaL_tracebackinstead of callingdebug.traceback. We have lua53-compat which backfills this function for PUC 5.1 and it's available by default from every other Lua we support.