Skip to content

deps: bump lua-openssl 0.11.0-2#311

Merged
zhaozg merged 2 commits intoluvit:masterfrom
mischief:openbsd
Jan 18, 2026
Merged

deps: bump lua-openssl 0.11.0-2#311
zhaozg merged 2 commits intoluvit:masterfrom
mischief:openbsd

Conversation

@mischief
Copy link
Contributor

@mischief mischief commented Jan 15, 2026

bump to 0.11.0-2 of lua-openssl which contains several libressl fixes.

this allows luvi to build on openbsd 7.8 with '-DWithOpenSSL=ON -DWithSharedOpenSSL=ON'.

@mischief
Copy link
Contributor Author

@zhaozg any ideas about the ci failures?

@truemedian
Copy link
Member

We generally try to avoid using untagged dependency versions because releases tend to have more effort put into them to ensure that the library as a whole functions as expected.

So we'd need lua-openssl to release the next lua-openssl update, then we can use that commit here in luvi; instead of pulling some random commit from the middle of a development cycle.

@mischief
Copy link
Contributor Author

ok. unfortunately, the previous tag does not have the libressl fixes.

@mischief mischief marked this pull request as draft January 16, 2026 17:57
@zhaozg
Copy link
Member

zhaozg commented Jan 17, 2026

@zhaozg any ideas about the ci failures?

I made a 0.11.0 lua-openssl release, a few times CI will publish it, please do some update.

@mischief
Copy link
Contributor Author

updated to lua-openssl 0.11.0-1.

@mischief mischief changed the title deps: bump lua-openssl deps: bump lua-openssl 0.11.0-1 Jan 17, 2026
@mischief mischief marked this pull request as ready for review January 17, 2026 09:35
@zhaozg
Copy link
Member

zhaozg commented Jan 17, 2026

macos CI error:

Missing some files

@zhaozg
Copy link
Member

zhaozg commented Jan 17, 2026

msvc fail: https://github.com/luvit/luvi/actions/runs/21093189383/job/60667700396?pr=311#step:6:3836 that caused in lua-openssl, let me fix it.

@zhaozg
Copy link
Member

zhaozg commented Jan 18, 2026

Copy link
Member

@zhaozg zhaozg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update lua-openssl to 0.11.0-2

bump to 0.11.0-2 of lua-openssl which contains several libressl fixes.

this allows luvi to build on openbsd 7.8 with '-DWithOpenSSL=ON
-DWithSharedOpenSSL=ON'.
@mischief mischief changed the title deps: bump lua-openssl 0.11.0-1 deps: bump lua-openssl 0.11.0-2 Jan 18, 2026
Copy link
Member

@zhaozg zhaozg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, others fail not releated

@zhaozg zhaozg merged commit 13b6a20 into luvit:master Jan 18, 2026
270 of 306 checks passed
@mischief mischief deleted the openbsd branch January 19, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants