Skip to content

ci: use macos-15-intel replace macos-13#312

Merged
zhaozg merged 2 commits intoluvit:masterfrom
zhaozg:master
Jan 19, 2026
Merged

ci: use macos-15-intel replace macos-13#312
zhaozg merged 2 commits intoluvit:masterfrom
zhaozg:master

Conversation

@zhaozg
Copy link
Member

@zhaozg zhaozg commented Jan 18, 2026

No description provided.

@zhaozg zhaozg force-pushed the master branch 3 times, most recently from 9d0f73c to f7db4d1 Compare January 19, 2026 09:01
@squeek502
Copy link
Member

Alternate fix that keeps the for loop:

--- a/src/lua/init.lua
+++ b/src/lua/init.lua
@@ -115,11 +115,12 @@ return function(args)
   for i = 1, #args do
     local arg = args[i]
     if arg == "--" then
+      local appArgsStart = i
       if #bundles == 0 then
-        i = i + 1
-        bundles[1] = args[i]
+        appArgsStart = appArgsStart + 1
+        bundles[1] = args[appArgsStart]
       end
-      for j = i + 1, #args do
+      for j = appArgsStart + 1, #args do
         appArgs[#appArgs + 1] = args[j]
       end
       break

@zhaozg
Copy link
Member Author

zhaozg commented Jan 19, 2026

EDIT:

The fix is good.

Alternate fix that keeps the for loop:

--- a/src/lua/init.lua
+++ b/src/lua/init.lua
@@ -115,11 +115,12 @@ return function(args)
   for i = 1, #args do
     local arg = args[i]
     if arg == "--" then
+      local appArgsStart = i
       if #bundles == 0 then
-        i = i + 1
-        bundles[1] = args[i]
+        appArgsStart = appArgsStart + 1
+        bundles[1] = args[appArgsStart]
       end
-      for j = i + 1, #args do
+      for j = appArgsStart + 1, #args do
         appArgs[#appArgs + 1] = args[j]
       end
       break

And

t = { 1, 2, 3, 4, 5}
for i=1, #t do
  print(i, t[i])
  if (i==2) then
    i = i+1
  end
end

lua 5.4, output

1	1
2	2
3	3
4	4
5	5

So i not be really modify in for block

@squeek502
Copy link
Member

The loop always stops because of the break

@zhaozg zhaozg merged commit 17c502d into luvit:master Jan 19, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants