Creating a script instead of code duplication

Author: MaticTonin

.github/scripts/smoke_depthai.py

@@ -0,0 +1,16 @@
+import os, sys, traceback, platform
+
+try:
+    import depthai as dai
+except Exception:
+    traceback.print_exc()
+    sys.exit(1)
+
+expected = os.environ.get("EXPECTED_VERSION") or os.environ.get("ver")
+installed = getattr(dai, "__version__", "<unknown>")
+if installed != expected:
+    print(f"Version mismatch: installed {installed} vs expected {expected}", file=sys.stderr)
+    sys.exit(1)
+
+print("depthai:", installed)
+print("python:", platform.python_version(), "ABI:", sys.implementation.cache_tag)

.github/workflows/python-main.yml

@@ -414,30 +414,13 @@ jobs:
 
           # Install from Artifactory snapshot
           python -m pip install -U pip
-          python -m pip uninstall -y depthai || true
-          python -m pip install -U --prefer-binary \
+          python -m pip install --force-reinstall -U --prefer-binary \
             --extra-index-url "$ARTIFACTORY_URL/luxonis-python-snapshot-local" \
             "depthai==$ver" \
             --trusted-host 3.145.46.25
 
-          # Smoke test: fail hard on any exception or version mismatch
-          ver="$ver" "$PYBIN" - <<'PY'
-          import os, sys, traceback, platform
-          try:
-              import depthai as dai
-          except Exception:
-              traceback.print_exc()
-              sys.exit(1)
-
-          expected = os.environ["ver"]  # read the env var you passed in
-          installed = getattr(dai, "__version__", "<unknown>")
-          if installed != expected:
-              print(f"Version mismatch: installed {installed} vs expected {expected}", file=sys.stderr)
-              sys.exit(1)
-
-          print("depthai:", installed)
-          print("python:", platform.python_version(), "ABI:", sys.implementation.cache_tag)
-          PY
+          EXPECTED_VERSION="$ver" python .github/scripts/smoke_depthai.py
+
   # This job builds wheels for x86_64 arch
   build-linux-x86_64:
     needs: build-docstrings
@@ -559,27 +542,10 @@ jobs:
           # Install from Artifactory snapshot
           "$PYBIN" -m ensurepip --upgrade || true
           "$PYBIN" -m pip install -U pip
-          "$PYBIN" -m pip uninstall -y depthai || true
-          "$PYBIN" -m pip install -U --prefer-binary --extra-index-url "$ARTIFACTORY_URL/luxonis-python-snapshot-local" "depthai==$ver" --trusted-host 3.145.46.25
+          "$PYBIN" -m pip install --force-reinstall -U --prefer-binary --extra-index-url "$ARTIFACTORY_URL/luxonis-python-snapshot-local" "depthai==$ver" --trusted-host 3.145.46.25
 
           # Smoke test: fail hard on any exception or version mismatch
-          ver="$ver" "$PYBIN" - <<'PY'
-          import os, sys, traceback, platform
-          try:
-              import depthai as dai
-          except Exception:
-              traceback.print_exc()
-              sys.exit(1)
-
-          expected = os.environ["ver"]  # read the env var you passed in
-          installed = getattr(dai, "__version__", "<unknown>")
-          if installed != expected:
-              print(f"Version mismatch: installed {installed} vs expected {expected}", file=sys.stderr)
-              sys.exit(1)
-
-          print("depthai:", installed)
-          print("python:", platform.python_version(), "ABI:", sys.implementation.cache_tag)
-          PY
+          EXPECTED_VERSION="$ver" python .github/scripts/smoke_depthai.py
 
   # This job builds wheels for ARM64 arch
   build-linux-arm64:
@@ -704,27 +670,9 @@ jobs:
           # Install from Artifactory snapshot
           "$PYBIN" -m ensurepip --upgrade || true
           "$PYBIN" -m pip install -U pip
-          "$PYBIN" -m pip uninstall -y depthai || true
-          "$PYBIN" -m pip install -U --prefer-binary --extra-index-url "$ARTIFACTORY_URL/luxonis-python-snapshot-local" "depthai==$ver" --trusted-host 3.145.46.25
+          "$PYBIN" -m pip install --force-reinstall -U --prefer-binary --extra-index-url "$ARTIFACTORY_URL/luxonis-python-snapshot-local" "depthai==$ver" --trusted-host 3.145.46.25
 
-          # Smoke test: fail hard on any exception or version mismatch
-          ver="$ver" "$PYBIN" - <<'PY'
-          import os, sys, traceback, platform
-          try:
-              import depthai as dai
-          except Exception:
-              traceback.print_exc()
-              sys.exit(1)
-
-          expected = os.environ["ver"]  # read the env var you passed in
-          installed = getattr(dai, "__version__", "<unknown>")
-          if installed != expected:
-              print(f"Version mismatch: installed {installed} vs expected {expected}", file=sys.stderr)
-              sys.exit(1)
-
-          print("depthai:", installed)
-          print("python:", platform.python_version(), "ABI:", sys.implementation.cache_tag)
-          PY
+          EXPECTED_VERSION="$ver" "$PYBIN" .github/scripts/smoke_depthai.py
 
   combine-windows-x86_64-wheels:
     needs: build-windows-x86_64
@@ -777,16 +725,13 @@ jobs:
 
           # Install from Artifactory snapshot
           python -m pip install -U pip
-          python -m pip uninstall -y depthai 2>$null | Out-Null
-          python -m pip install -U --prefer-binary `
+          python -m pip install --force-reinstall -U --prefer-binary `
             --extra-index-url "$env:ARTIFACTORY_URL/luxonis-python-snapshot-local" `
             "depthai==$ver" `
             --trusted-host 3.145.46.25
 
           # Smoke test (no heredoc; YAML-safe). Fail on import error or version mismatch.
-          $env:EXPECTED_VERSION = $ver
-          python -c "import os,sys,platform; import depthai as d; e=os.environ['EXPECTED_VERSION']; i=getattr(d,'__version__','<unknown>'); assert i==e, f'Version mismatch: {i} vs {e}'; print('depthai:', i); print('python:', platform.python_version(), 'ABI:', sys.implementation.cache_tag)"
-
+          $env:EXPECTED_VERSION = $ver "python .github/scripts/smoke_depthai.py
   release:
     if: startsWith(github.ref, 'refs/tags/v')
     # needs: [pytest, build-linux-armhf, build-windows-x86_64, build-macos-x86_64, build-macos-arm64, build-linux-x86_64, build-linux-arm64]