Make XLinkProperties internal

Author: lnotspotl

bindings/python/src/pipeline/node/internal/XLinkInBindings.cpp

@@ -34,12 +34,12 @@ void bind_xlinkin(pybind11::module& m, void* pCallstack) {
         .def_readwrite("numFrames", &XLinkInProperties::numFrames);
 
     // Node
-    xlinkIn.def_readonly("out", &XLinkIn::out, DOC(dai, node, XLinkIn, out))
-        .def("setStreamName", &XLinkIn::setStreamName, py::arg("streamName"), DOC(dai, node, XLinkIn, setStreamName))
-        .def("setMaxDataSize", &XLinkIn::setMaxDataSize, py::arg("maxDataSize"), DOC(dai, node, XLinkIn, setMaxDataSize))
-        .def("setNumFrames", &XLinkIn::setNumFrames, py::arg("numFrames"), DOC(dai, node, XLinkIn, setNumFrames))
-        .def("getStreamName", &XLinkIn::getStreamName, DOC(dai, node, XLinkIn, getStreamName))
-        .def("getMaxDataSize", &XLinkIn::getMaxDataSize, DOC(dai, node, XLinkIn, getMaxDataSize))
-        .def("getNumFrames", &XLinkIn::getNumFrames, DOC(dai, node, XLinkIn, getNumFrames));
+    xlinkIn.def_readonly("out", &XLinkIn::out, DOC(dai, node, internal, XLinkIn, out))
+        .def("setStreamName", &XLinkIn::setStreamName, py::arg("streamName"), DOC(dai, node, internal, XLinkIn, setStreamName))
+        .def("setMaxDataSize", &XLinkIn::setMaxDataSize, py::arg("maxDataSize"), DOC(dai, node, internal, XLinkIn, setMaxDataSize))
+        .def("setNumFrames", &XLinkIn::setNumFrames, py::arg("numFrames"), DOC(dai, node, internal, XLinkIn, setNumFrames))
+        .def("getStreamName", &XLinkIn::getStreamName, DOC(dai, node, internal, XLinkIn, getStreamName))
+        .def("getMaxDataSize", &XLinkIn::getMaxDataSize, DOC(dai, node, internal, XLinkIn, getMaxDataSize))
+        .def("getNumFrames", &XLinkIn::getNumFrames, DOC(dai, node, internal, XLinkIn, getNumFrames));
     daiNodeInternalModule.attr("XLinkIn").attr("Properties") = xlinkInProperties;
 }

bindings/python/src/pipeline/node/internal/XLinkOutBindings.cpp

@@ -34,12 +34,12 @@ void bind_xlinkout(pybind11::module& m, void* pCallstack) {
         .def_readwrite("metadataOnly", &XLinkOutProperties::metadataOnly);
 
     // Node
-    xlinkOut.def_readonly("input", &XLinkOut::input, DOC(dai, node, XLinkOut, input))
-        .def("setStreamName", &XLinkOut::setStreamName, py::arg("streamName"), DOC(dai, node, XLinkOut, setStreamName))
-        .def("setFpsLimit", &XLinkOut::setFpsLimit, py::arg("fpsLimit"), DOC(dai, node, XLinkOut, setFpsLimit))
-        .def("getStreamName", &XLinkOut::getStreamName, DOC(dai, node, XLinkOut, getStreamName))
-        .def("getFpsLimit", &XLinkOut::getFpsLimit, DOC(dai, node, XLinkOut, getFpsLimit))
-        .def("setMetadataOnly", &XLinkOut::setMetadataOnly, DOC(dai, node, XLinkOut, setMetadataOnly))
-        .def("getMetadataOnly", &XLinkOut::getMetadataOnly, DOC(dai, node, XLinkOut, getMetadataOnly));
+    xlinkOut.def_readonly("input", &XLinkOut::input, DOC(dai, node, internal, XLinkOut, input))
+        .def("setStreamName", &XLinkOut::setStreamName, py::arg("streamName"), DOC(dai, node, internal, XLinkOut, setStreamName))
+        .def("setFpsLimit", &XLinkOut::setFpsLimit, py::arg("fpsLimit"), DOC(dai, node, internal, XLinkOut, setFpsLimit))
+        .def("getStreamName", &XLinkOut::getStreamName, DOC(dai, node, internal, XLinkOut, getStreamName))
+        .def("getFpsLimit", &XLinkOut::getFpsLimit, DOC(dai, node, internal, XLinkOut, getFpsLimit))
+        .def("setMetadataOnly", &XLinkOut::setMetadataOnly, DOC(dai, node, internal, XLinkOut, setMetadataOnly))
+        .def("getMetadataOnly", &XLinkOut::getMetadataOnly, DOC(dai, node, internal, XLinkOut, getMetadataOnly));
     daiNodeInternalModule.attr("XLinkOut").attr("Properties") = xlinkOutProperties;
 }

include/depthai/pipeline/node/host/Record.hpp

@@ -3,7 +3,7 @@
 #include <depthai/pipeline/ThreadedNode.hpp>
 
 // shared
-#include <depthai/properties/XLinkOutProperties.hpp>
+#include <depthai/properties/internal/XLinkOutProperties.hpp>
 
 // project
 #include <depthai/pipeline/datatype/Buffer.hpp>
@@ -18,6 +18,8 @@
 namespace dai {
 namespace node {
 
+using XLinkOutProperties = ::dai::internal::XLinkOutProperties;
+
 /**
  * @brief RecordVideo node, used to record a video source stream to a file
  */

include/depthai/pipeline/node/host/Replay.hpp

@@ -5,7 +5,7 @@
 #include <memory>
 
 // shared
-#include <depthai/properties/XLinkOutProperties.hpp>
+#include <depthai/properties/internal/XLinkOutProperties.hpp>
 
 // project
 #include <depthai/pipeline/datatype/Buffer.hpp>
@@ -17,6 +17,8 @@
 namespace dai {
 namespace node {
 
+using XLinkOutProperties = ::dai::internal::XLinkOutProperties;
+
 /**
  * @brief Replay node, used to replay a file to a source node
  */

include/depthai/pipeline/node/internal/XLinkIn.hpp

@@ -3,12 +3,14 @@
 #include <depthai/pipeline/DeviceNode.hpp>
 
 // shared
-#include <depthai/properties/XLinkInProperties.hpp>
+#include <depthai/properties/internal/XLinkInProperties.hpp>
 
 namespace dai {
 namespace node {
 namespace internal {
 
+using XLinkInProperties = ::dai::internal::XLinkInProperties;
+
 /**
  * @brief XLinkIn node. Receives messages over XLink.
  */

include/depthai/pipeline/node/internal/XLinkOut.hpp

@@ -3,12 +3,14 @@
 #include <depthai/pipeline/DeviceNode.hpp>
 
 // shared
-#include <depthai/properties/XLinkOutProperties.hpp>
+#include <depthai/properties/internal/XLinkOutProperties.hpp>
 
 namespace dai {
 namespace node {
 namespace internal {
 
+using XLinkOutProperties = ::dai::internal::XLinkOutProperties;
+
 /**
  * @brief XLinkOut node. Sends messages over XLink.
  */

include/depthai/properties/XLinkInProperties.hpp renamed to include/depthai/properties/internal/XLinkInProperties.hpp

@@ -4,6 +4,7 @@
 #include "depthai/xlink/XLinkConstants.hpp"
 
 namespace dai {
+namespace internal {
 
 /**
  * Specify properties for XLinkIn such as stream name, ...
@@ -27,4 +28,5 @@ struct XLinkInProperties : PropertiesSerializable<Properties, XLinkInProperties>
 
 DEPTHAI_SERIALIZE_EXT(XLinkInProperties, streamName, maxDataSize, numFrames);
 
+}  // namespace internal
 }  // namespace dai

include/depthai/properties/XLinkOutProperties.hpp renamed to include/depthai/properties/internal/XLinkOutProperties.hpp

@@ -3,6 +3,7 @@
 #include "depthai/properties/Properties.hpp"
 
 namespace dai {
+namespace internal {
 
 /**
  * Specify properties for XLinkOut such as stream name, ...
@@ -26,4 +27,5 @@ struct XLinkOutProperties : PropertiesSerializable<Properties, XLinkOutPropertie
 
 DEPTHAI_SERIALIZE_EXT(XLinkOutProperties, maxFpsLimit, streamName, metadataOnly);
 
+}  // namespace internal
 }  // namespace dai