Merge pull request #1353 from luxonis/v3_develop

Author: moratom

.clang-tidy

@@ -1,8 +1,49 @@
 ---
-Checks:          '-*,clang-analyzer-*,clang-diagnostic-*,readability-*,modernize-*,boost-*,bugprone-*,cppcoreguidelines-*,google-*,hicpp-*,performance-*,readability-*,-google-readability-namespace-comments,-readability-inconsistent-declaration-parameter-name,-readability-braces-around-statements,-hicpp-signed-bitwise,-google-runtime-references,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-readability-magic-numbers,-hicpp-explicit-conversions,-hicpp-uppercase-literal-suffix,-readability-uppercase-literal-suffix,-hicpp-no-array-decay,-hicpp-special-member-functions,-bugprone-narrowing-conversions,-modernize-use-nodiscard,-google-readability-braces-around-statements,-hicpp-braces-around-statements,-bugprone-suspicious-semicolon,-readability-named-parameter,-hicpp-named-parameter,-modernize-use-trailing-return-type,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-pro-bounds-constant-array-index'
+Checks: >
+  -*,
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  readability-*,
+  modernize-*,
+  boost-*,
+  bugprone-*,
+  cppcoreguidelines-*,
+  google-*,
+  hicpp-*,
+  performance-*,
+  readability-*,
+  -readability-identifier-length,
+  -google-readability-namespace-comments,
+  -readability-inconsistent-declaration-parameter-name,
+  -readability-braces-around-statements,
+  -hicpp-signed-bitwise,
+  -google-runtime-references,
+  -cppcoreguidelines-avoid-magic-numbers,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -readability-magic-numbers,
+  -hicpp-explicit-conversions,
+  -hicpp-uppercase-literal-suffix,
+  -readability-uppercase-literal-suffix,
+  -hicpp-no-array-decay,
+  -hicpp-special-member-functions,
+  -bugprone-narrowing-conversions,
+  -modernize-use-nodiscard,
+  -google-readability-braces-around-statements,
+  -hicpp-braces-around-statements,
+  -bugprone-suspicious-semicolon,
+  -readability-named-parameter,
+  -hicpp-named-parameter,
+  -modernize-use-trailing-return-type,
+  -cppcoreguidelines-non-private-member-variables-in-classes,
+  -cppcoreguidelines-pro-bounds-constant-array-index,
+  -modernize-concat-nested-namespaces,
+
 # TODO(themarpe) - Gradually bring back errors
 #WarningsAsErrors: 'modernize-*,cppcoreguidelines-*,boost-*,performance-*,google-build-using-namespace,readability-else-after-return,google-readability-todo'
-WarningsAsErrors: 'bugprone-throw-keyword-missing'
+WarningsAsErrors: >
+  bugprone-throw-keyword-missing,
+  bugprone-unchecked-optional-access,
+
 HeaderFilterRegex: 'core/.*\.hpp'
 AnalyzeTemporaryDtors: false
 FormatStyle:     .clang-format
@@ -280,6 +321,3 @@ CheckOptions:
     value:           UPPER_CASE
   - key:             readability-identifier-naming.IgnoreMainLikeFunctions
     value:           1
-
-    
-

.github/workflows/bom.yml

@@ -1,5 +1,94 @@
-name: BOM
+name: BOM Testing
 
-# Only allow manual trigger
 on:
+  push:
+    branches:
+      - v3_develop
+    tags:
+      - 'v*'
   workflow_dispatch:
+    inputs:
+      distinct_id:
+        description: 'run identifier'
+        required: false
+      testbed:
+          description: 'On what testbed will tests be run'
+          required: false
+          type: string
+      reservation_name:
+          description: 'Reservation name - usually usually unique identifier of root CI run'
+          required: false
+          type: string
+      luxonis_os:
+          description: 'Which RVC4 os version to install before starting tests'
+          required: false
+          type: string
+      hold_reservation:
+        description: 'If this is set to true testbed will stay reserved after process is done - reccomended for CI use'
+        required: false
+        type: boolean
+      depthai:
+        required: false
+        type: string
+        default: "v3_develop"
+        description: "Version for depthai"
+
+jobs:
+  id:
+    name: Workflow ID Provider
+    runs-on: ubuntu-latest
+    if: github.event_name == 'workflow_dispatch'
+    steps:
+      - name: echo distinct ID ${{ github.event.inputs.distinct_id }}
+        run: echo ${{ github.event.inputs.distinct_id }}
+
+  # Testing
+  rvc4_test_bom:
+      env:
+        VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite"
+      if: github.event_name == 'workflow_dispatch'
+      strategy:
+        matrix:
+          arch: ['x64']
+          flavor: ['vanilla']
+        fail-fast: false
+      runs-on: ['self-hosted', 'testbed-runner']
+
+      steps:
+      - uses: actions/checkout@v3
+
+      - name: Checkout source code from tag
+        uses: actions/checkout@v3
+        with:
+            ref: ${{ github.event.inputs.depthai }}
+            path: depthai-core
+            submodules: 'recursive'
+
+      - name: Prepare HIL Framework
+        run: source scripts/hil/prepare_hil_framework.sh
+
+      - name: Configure, Build and Test
+        run: |
+          rm -rf depthai-core/scripts/hil/ && mkdir -p depthai-core/scripts/hil/ && cp -r scripts/hil/* depthai-core/scripts/hil/
+          rm depthai-core/tests/run_tests.py && cp tests/run_tests.py depthai-core/tests/run_tests.py
+          cd depthai-core
+
+          if [[ -n "${{ github.event.inputs.testbed }}" ]]; then
+            TESTBED_OPTION="--testbed ${{ github.event.inputs.testbed }}"
+          fi
+
+          if [[ -n "${{ github.event.inputs.reservation_name }}" ]]; then
+            RESERVATION_OPTION="--reservation-name ${{ github.event.inputs.reservation_name }}"
+          else
+            export RESERVATION_NAME="https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID#rvc4-depthai-bom"
+            RESERVATION_OPTION="--reservation-name $RESERVATION_NAME"
+          fi
+
+          if [[ "${{ github.event.inputs.hold_reservation }}" == 'true' ]]; then
+            HOLD_RESERVATION="--hold-reservation"
+          fi
+
+          if [[ -n  "${{ github.event.inputs.luxonis_os }}" ]]; then
+            UPDATE_LUXONIS_OS="--rvc4-os-version ${{ github.event.inputs.luxonis_os }}"
+          fi
+          exec hil $HOLD_RESERVATION --models "oak4_pro or oak4_d" $TESTBED_OPTION $RESERVATION_OPTION $UPDATE_LUXONIS_OS --wait --sync-workspace  --commands 'cd /tmp/depthai-core|| exit' 'scripts/hil/run_hil_tests.sh ${{ matrix.flavor }} --rvc4'