Skip to content

Commit f970bfc

Browse files
themarpeSzabolcsGergely
authored andcommitted
Addresses CMake 3.20 regression in parsing '--parallel' ('-j') option
1 parent b055a0a commit f970bfc

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
- name: Configure project
5151
run: cmake -S . -B build -DDEPTHAI_PYTHON_FORCE_DOCSTRINGS=ON -DDEPTHAI_PYTHON_DOCSTRINGS_OUTPUT="$PWD/docstrings/depthai_python_docstring.hpp"
5252
- name: Build target 'pybind11_mkdoc'
53-
run: cmake --build build --parallel --target pybind11_mkdoc
53+
run: cmake --build build --target pybind11_mkdoc --parallel
5454
- name: Upload docstring artifacts
5555
uses: actions/upload-artifact@v2
5656
with:
@@ -247,7 +247,7 @@ jobs:
247247
- name: Build and install depthai-core
248248
run: |
249249
cmake -S depthai-core/ -B build_core -D CMAKE_BUILD_TYPE=Release -D CMAKE_TOOLCHAIN_FILE=$PWD/cmake/toolchain/pic.cmake
250-
cmake --build build_core --parallel --target install
250+
cmake --build build_core --target install --parallel
251251
echo "DEPTHAI_INSTALLATION_DIR=$PWD/build_core/install/" >> $GITHUB_ENV
252252
253253
- name: Append build hash if not a tagged commit
@@ -309,7 +309,7 @@ jobs:
309309
- name: Build and install depthai-core
310310
run: |
311311
cmake -S depthai-core/ -B build_core -D CMAKE_BUILD_TYPE=Release -D CMAKE_TOOLCHAIN_FILE=$PWD/cmake/toolchain/pic.cmake
312-
cmake --build build_core --parallel --target install
312+
cmake --build build_core --target install --parallel
313313
echo "DEPTHAI_INSTALLATION_DIR=$PWD/build_core/install/" >> $GITHUB_ENV
314314
315315
- name: Append build hash if not a tagged commit

README.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Documentation is available over at [Luxonis DepthAI API](https://docs.luxonis.co
3434
python3 -m pip install -U pip
3535
python3 -m pip install -r docs/requirements.txt
3636
cmake -S . -B build -D DEPTHAI_BUILD_DOCS=ON -D DEPTHAI_PYTHON_BUILD_DOCS=ON
37-
cmake --build build --parallel --target sphinx
37+
cmake --build build --target sphinx --parallel
3838
python3 -m http.server --bind 0.0.0.0 8000 --directory build/docs/sphinx
3939
```
4040
@@ -44,7 +44,7 @@ Documentation is available over at [Luxonis DepthAI API](https://docs.luxonis.co
4444
in a new terminal window to update the website source
4545
4646
```
47-
cmake --build build --parallel --target sphinx
47+
cmake --build build --target sphinx --parallel
4848
```
4949
5050
Then refresh your page - it should load the updated website that was just built
@@ -74,15 +74,22 @@ See: [depthai-core dependencies](https://github.com/luxonis/depthai-core#depende
7474
To build a shared library from source perform the following:
7575
```
7676
mkdir build && cd build
77-
cmake ..
77+
cmake .. [-D PYTHON_EXECUTABLE=/full/path/to/python]
7878
cmake --build . --parallel
7979
```
8080
81+
Where `-D PYTHON_EXECUTABLE` option can optionally specify an exact Python executable to use for building.
82+
8183
To build a wheel, execute the following
8284
```
8385
python3 -m pip wheel . -w wheelhouse
8486
```
8587
88+
To build and install using pip:
89+
```
90+
python3 -m pip install .
91+
```
92+
8693
## Running tests
8794
8895
To run the tests build the library with the following options

docs/docker/update_docs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
set -e
44

5-
cmake --build build --parallel --target sphinx
5+
cmake --build build --target sphinx --parallel
66

77
# fix missing index.css file
88
cp /app/docs/source/_static/css/* /app/build/docs/sphinx/_static/css

0 commit comments

Comments
 (0)