Add workflow_call support in unittests workflow#149
Merged
Conversation
Test Results 6 files 6 suites 8m 11s ⏱️ Results for commit a81def9. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
jkbmrz
approved these changes
May 8, 2025
Contributor
jkbmrz
left a comment
jkbmrz
left a comment
There was a problem hiding this comment.
LGTM code-wise but I lack some context/purpose of why the changes (i.e. external calls to the workflow) are needed.
klemen1999
approved these changes
May 8, 2025
Collaborator
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
LGTM
@jkbmrz : Context is BOM testing so we can check that every new luxonis-ml release is compatible with all other repos
JSabadin
changed the title
workflow_call support in unittests workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR Description:
workflow_callwithml_refandtools_refinputstoolsat specified ref when invoked externallyluxonis-mlversion viaml_reftoolsSpecification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable