Fix breakage with -DLODEPNG_NO_COMPILE_CRC#161
Open
hpjansson wants to merge 1 commit intolvandeve:masterfrom
Open
Fix breakage with -DLODEPNG_NO_COMPILE_CRC#161hpjansson wants to merge 1 commit intolvandeve:masterfrom
hpjansson wants to merge 1 commit intolvandeve:masterfrom
Conversation
Compiling with -DLODEPNG_NO_COMPILE_CRC would lead to linker errors, since lodepng_crc32() was still being referenced: liblodepng.a(lodepng.o): in function `lodepng_chunk_check_crc': lodepng.cpp:2496: undefined reference to `lodepng_crc32' liblodepng.a(lodepng.o): in function `lodepng_chunk_generate_crc': lodepng.cpp:2503: undefined reference to `lodepng_crc32' liblodepng.a(lodepng.o): in function `lodepng_inspect': lodepng.cpp:4083: undefined reference to `lodepng_crc32' Just #ifdef out the references too, ignoring CRCs in the decoder and generating a zero CRC in the encoder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling with -DLODEPNG_NO_COMPILE_CRC would lead to linker errors, since
lodepng_crc32() was still being referenced:
liblodepng.a(lodepng.o): in function
lodepng_chunk_check_crc:lodepng.cpp:2496: undefined reference to
lodepng_crc32liblodepng.a(lodepng.o): in function
lodepng_chunk_generate_crc:lodepng.cpp:2503: undefined reference to
lodepng_crc32liblodepng.a(lodepng.o): in function
lodepng_inspect:lodepng.cpp:4083: undefined reference to
lodepng_crc32Just #ifdef out the references too, ignoring CRCs in the decoder and
generating a zero CRC in the encoder.