Open
Conversation
The variable unsigned error = 0; was initialised but never used. In this function errors was realised as a return code, f.e.: if(bpp == 0) return 31; So variable error is not needed here.
|
FYI, cleaner diff: https://github.com/lvandeve/lodepng/pull/60/files?w=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a member of the Pinguem.ru competition on finding errors in open source projects. A bug, found using PVS-Studio:
lodepng/lodepng.cpp 5265 warn V547 Expression '!error' is always true.
The variable unsigned error = 0; was initialised but never used. In this function errors was realised as a return code, f.e.:
if(bpp == 0) return 31;
So variable error is not deeded here.