Add cmake support with cmake-config file by NeroBurner · Pull Request #82 · lvandeve/lodepng

NeroBurner · 2019-01-17T13:34:37Z

Add full cmake support. The project can either be used with
add_subdirectory or be installed into the system (or some other
directory) and be found with find_package(lodepng). In both cases the
cmake target lodepng::lodepng is all that needs to be linked.

Having an install target also makes packaging easier.

add libraries
- loadepng
- lodepng_util
add executables (also installed)
- pngdetail
generate lodepng-config.cmake and install in lib/cmake/lodepng
add unittest and target test (enabled by flag ENABLE_TESTING)
add benchmark (enabled by flag BUILD_BENCHMARK)
add examples (enabled by flag BUILD_EXAMPLES)

note: I was only able to install SDL2 from my package manager, but
benchmark, example_opengl and example_sdl use SDL (1)

If you have any questions about this commit I'd be happy to clear out any misunderstandings

cmake -S . -B _build -DCMAKE_INSTALL_PREFIX="${PWD}/_install" -DCMAKE_BUILD_TYPE=Release
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/neroburner/repos/external/lodepng/_build

$ cmake --build _build --target install
Scanning dependencies of target lodepng
[ 12%] Building CXX object CMakeFiles/lodepng.dir/lodepng.cpp.o
[ 25%] Linking CXX static library liblodepng.a
[ 25%] Built target lodepng
Scanning dependencies of target lodepng_util
[ 37%] Building CXX object CMakeFiles/lodepng_util.dir/lodepng_util.cpp.o
[ 50%] Linking CXX static library liblodepng_util.a
[ 50%] Built target lodepng_util
Scanning dependencies of target lodepng_unittest
[ 62%] Building CXX object CMakeFiles/lodepng_unittest.dir/lodepng_unittest.cpp.o
[ 75%] Linking CXX executable lodepng_unittest
[ 75%] Built target lodepng_unittest
Scanning dependencies of target pngdetail
[ 87%] Building CXX object CMakeFiles/pngdetail.dir/pngdetail.cpp.o
[100%] Linking CXX executable pngdetail
[100%] Built target pngdetail
Install the project...
-- Install configuration: "Release"
-- Installing: /home/neroburner/repos/external/lodepng/_install/lib/liblodepng.a
-- Installing: /home/neroburner/repos/external/lodepng/_install/lib/liblodepng_util.a
-- Installing: /home/neroburner/repos/external/lodepng/_install/bin/pngdetail
-- Installing: /home/neroburner/repos/external/lodepng/_install/include/lodepng.h
-- Installing: /home/neroburner/repos/external/lodepng/_install/include/lodepng_util.h
-- Installing: /home/neroburner/repos/external/lodepng/_install/lib/cmake/lodepng/lodepng-config.cmake
-- Installing: /home/neroburner/repos/external/lodepng/_install/lib/cmake/lodepng/lodepng-targets.cmake
-- Installing: /home/neroburner/repos/external/lodepng/_install/lib/cmake/lodepng/lodepng-targets-release.cmake

ekg · 2019-03-14T09:19:24Z

I just realized that there are many cmakeification PRs here. Is this project not active anymore?

NeroBurner · 2019-03-15T08:28:26Z

not dead, @lvandeve still commits, but I think he is not interested in cmake support

ekg · 2019-03-15T14:15:44Z

In the end, it's just a CMakeLists.txt. It's very helpful when integrating this into other projects.

Add full cmake support. The project can either be used with `add_subdirectory` or be installed into the system (or some other directory) and be found with `find_package(lodepng)`. In both cases the cmake target `lodepng::lodepng` is all that needs to be linked. Having an install target also makes packaging easier. - add libraries - loadepng - lodepng_util - add executables (also installed) - pngdetail - generate lodepng-config.cmake and install in lib/cmake/lodepng - add unittest and target `test` (enabled by flag ENABLE_TESTING) - add benchmark (enabled by flag BUILD_BENCHMARK) - add examples (enabled by flag BUILD_EXAMPLES) note: I was only able to install SDL2 from my package manager, but benchmark, example_opengl and example_sdl use SDL (1)

NeroBurner · 2020-09-27T21:42:08Z

@aleksey-nikolaev could you review my attempt at adding CMake support for lodepng? Anything missing here?

aleksey-nikolaev

I think you need to refactoring your project first of all

aleksey-nikolaev · 2020-09-28T06:42:03Z

CMakeLists.txt

+option(ENABLE_TESTING "enable creation of unittest" ON)
+if(ENABLE_TESTING)
+  enable_testing()
+  add_executable(${CMAKE_PROJECT_NAME}_unittest lodepng_unittest.cpp)


You can move this block to the tests/CMakeList.txt. I think, it will be much readable if your main folder will not contain tests or any other unnecessary code.

aleksey-nikolaev · 2020-09-28T06:44:44Z

CMakeLists.txt

+option(BUILD_BENCHMARK "build benchmark for ${CMAKE_PROJECT_NAME}, requires SDL2" OFF)
+if(BUILD_BENCHMARK)
+  add_executable(${CMAKE_PROJECT_NAME}_benchmark lodepng_benchmark.cpp)
+  target_link_libraries(${CMAKE_PROJECT_NAME}_benchmark PRIVATE ${CMAKE_PROJECT_NAME}::${CMAKE_PROJECT_NAME})


As for the tests move this to the benchmark/CMakeList.txt

aleksey-nikolaev · 2020-09-28T06:49:04Z

CMakeLists.txt

+  add_executable(${CMAKE_PROJECT_NAME}_benchmark lodepng_benchmark.cpp)
+  target_link_libraries(${CMAKE_PROJECT_NAME}_benchmark PRIVATE ${CMAKE_PROJECT_NAME}::${CMAKE_PROJECT_NAME})
+  # SDL2 Dependency
+  find_package(SDL2 CONFIG REQUIRED)


I don't know what SDL2 is, but are you shure that when system will not contain this library the next if will work as expected?

aleksey-nikolaev · 2020-09-28T07:01:49Z

examples/CMakeLists.txt

+if (TARGET SDL2::SDL2)
+  message(STATUS "using TARGET SDL2::SDL2")
+else()
+  message(STATUS "no TARGET SDL2::SDL2, or SDL2, using variables")


How can you get here? Did you expect an older version of this library without SDL2::SDL2? If so, maybe it should be better to create your own SDL2Find.cmake instead of using SDL2_INCLUDE_DIRS directly.

aleksey-nikolaev · 2020-09-28T07:03:31Z

examples/CMakeLists.txt

+else()
+  message(STATUS "no TARGET SDL2::SDL2, or SDL2, using variables")
+endif()
+foreach(example


This for do nothing, isn' it?

aleksey-nikolaev · 2020-09-28T07:24:27Z

CMakeLists.txt

+project(lodepng)
+
+# define target to install and link tests against
+add_library(${CMAKE_PROJECT_NAME}


Also you can use option(BUILD_SHARED_LIBS "Build ${CMAKE_PROJECT_NAME} as shared library" OFF) if you care about type of library to being build

NeroBurner force-pushed the cmake-support branch from eb0e9e6 to acc4305 Compare February 18, 2019 12:19

lvandeve force-pushed the master branch from b4539da to 2febfe0 Compare January 12, 2020 09:41

NeroBurner force-pushed the cmake-support branch from acc4305 to c698025 Compare September 27, 2020 21:32

aleksey-nikolaev reviewed Sep 28, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cmake support with cmake-config file#82

Add cmake support with cmake-config file#82
NeroBurner wants to merge 1 commit intolvandeve:masterfrom
NeroBurner:cmake-support

NeroBurner commented Jan 17, 2019

Uh oh!

ekg commented Mar 14, 2019

Uh oh!

NeroBurner commented Mar 15, 2019

Uh oh!

ekg commented Mar 15, 2019

Uh oh!

NeroBurner commented Sep 27, 2020

Uh oh!

aleksey-nikolaev left a comment

Uh oh!

aleksey-nikolaev Sep 28, 2020

Uh oh!

aleksey-nikolaev Sep 28, 2020

Uh oh!

aleksey-nikolaev Sep 28, 2020

Uh oh!

aleksey-nikolaev Sep 28, 2020

Uh oh!

aleksey-nikolaev Sep 28, 2020

Uh oh!

aleksey-nikolaev Sep 28, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

NeroBurner commented Jan 17, 2019

Uh oh!

ekg commented Mar 14, 2019

Uh oh!

NeroBurner commented Mar 15, 2019

Uh oh!

ekg commented Mar 15, 2019

Uh oh!

NeroBurner commented Sep 27, 2020

Uh oh!

aleksey-nikolaev left a comment

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aleksey-nikolaev Sep 28, 2020 •

edited

Loading