Open
Conversation
Merge upstream
…qrt(D) by squaring and inversing theta
make
force-pushed
the
slight-performance-improvements
branch
from
cf493b7 to
e599275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that sqrt is not needed to calculate as inequation
max_width / sqrt(D) < thetaequals to inequation
D > max_width² / theta²(at least when all positive)and when
T = 1 / theta²can be precalculatedfinally leads to inequation
D > max_width² * TSeeing about 4% computation time decrease (from 100 seconds to 96 seconds) for learning phase with 1000 iterations for input of 10000 x 200 samples.