Skip to content

Fix ESP32 board variant build parameter, and fix M5Core2 make #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGNetHun merged 1 commit into from
Mar 15, 2025
Merged

Fix ESP32 board variant build parameter, and fix M5Core2 make #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README-LVGL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Here is the command to build ESP32 + LVGL which is compatible with ILI9341 drive

```
make -C mpy-cross
make -C ports/esp32 LV_CFLAGS="-DLV_COLOR_DEPTH=16" BOARD=ESP32_GENERIC VARIANT=SPIRAM deploy
make -C ports/esp32 LV_CFLAGS="-DLV_COLOR_DEPTH=16" BOARD=ESP32_GENERIC BOARD_VARIANT=SPIRAM deploy
```

Explanation about the parameters:
Expand Down
1 change: 1 addition & 0 deletions ports/esp32/boards/M5STACK_CORE2/board.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"features": [
"BLE",
"WiFi",
"Dual-core",
"External Flash",
"External RAM",
"SDCard",
Expand Down
1 change: 1 addition & 0 deletions ports/esp32/boards/M5STACK_CORE2/mpconfigboard.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
set(SDKCONFIG_DEFAULTS
boards/sdkconfig.base
${SDKCONFIG_IDF_VERSION_SPECIFIC}
boards/sdkconfig.ble
boards/sdkconfig.240mhz
boards/sdkconfig.spiram
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-esp32.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ cd $MICROPYTHON
make -C mpy-cross

cd $MICROPYTHON/ports/esp32
make BOARD=$BOARD VARIANT=$VARIANT
make BOARD=$BOARD BOARD_VARIANT=$BOARD_VARIANT
2 changes: 1 addition & 1 deletion scripts/deploy-esp32.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ if [ -z "$BOARD" ]; then
fi

cd $MICROPYTHON/ports/esp32
make deploy BOARD=$BOARD VARIANT=$VARIANT
make deploy BOARD=$BOARD BOARD_VARIANT=$VARIANT
6 changes: 3 additions & 3 deletions scripts/menu-esp32.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ if [[ $choice -lt 1 || $choice -gt ${#configs[@]} ]]; then
exit 1
fi

# Set BOARD and VARIANT based on user choice
# Set BOARD and BOARD_VARIANT based on user choice
selected_config=(${configs[$((choice-1))]})
BOARD=${selected_config[0]}
VARIANT=${selected_config[1]:-""}
BOARD_VARIANT=${selected_config[1]:-""}

echo "Selected configuration: BOARD=$BOARD, VARIANT=$VARIANT"
echo "Selected configuration: BOARD=$BOARD, BOARD_VARIANT=$BOARD_VARIANT"
Loading