esp32: allow external USER_C_MODULES from command line #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGNetHun
requested changes
Jul 11, 2025
Collaborator
PGNetHun
left a comment
PGNetHun
left a comment
There was a problem hiding this comment.
Thanks for all these changes, it's super.
I have added only a few comments that need to be resolved, before merging to main.
| [submodule "user_modules/lv_binding_micropython"] | ||
| path = user_modules/lv_binding_micropython | ||
| url = https://github.com/lvgl/lv_binding_micropython.git | ||
| url = https://github.com/hero-not-found/lv_binding_micropython.git |
Collaborator
There was a problem hiding this comment.
- Please change back to original LVGL binding repo
- Create a separate PR in binding repo with your changes, and add link to it in this PR's description field (or comment).
| boards/ESP32_GENERIC_S3/sdkconfig.board | ||
| ) | ||
|
|
||
| set(LV_CFLAGS -DLV_COLOR_DEPTH=16 -DLV_COLOR_16_SWAP=1) |
Collaborator
There was a problem hiding this comment.
This is display-dependent code, please remove this line.
Collaborator
There was a problem hiding this comment.
Is it worth to include HW display drivers here in this file?
Like ili9341 or xpt2046 or TWatch...
I think this file could be simplified to initialize only SDL.
Author
|
Apologies - this PR was supposed to only include a single commit. I can clean up the other stuff and submit separately. Closing this PR for now and opening a new one with just the USER_C_MODULES change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The esp32 port hardcodes
USER_C_MODULESto point tolv_binding_micropythonand breaks the ability to pass in additional user modules via command line. This PR fixes that issueTesting
I successfully built the esp32 port both with and without additional user modules