Skip to content

fix(cli): bump open files limit on macOS and Linux #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mre wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −0
Open

fix(cli): bump open files limit on macOS and Linux #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lychee-bin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ tokio-stream = "0.1.18"
toml = "1.0.6"
url = "2.5.8"
quick-junit = "0.5.2"
rlimit = "0.11.0"


[dev-dependencies]
Expand Down
7 changes: 7 additions & 0 deletions lychee-bin/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ enum ExitCode {
const LYCHEEIGNORE_COMMENT_MARKER: &str = "#";

fn main() -> Result<()> {
// Increase the maximum number of open files on macOS and Linux.
// This is helpful because lychee opens many files concurrently during
// link extraction and checking, which can exceed the default limit
// of 256 open files on macOS. See https://github.com/lycheeverse/lychee/issues/1248
#[cfg(any(target_os = "macos", target_os = "linux"))]
Copy link
Member

@thomas-zahner thomas-zahner Mar 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peeking inside the function I see the guard #[cfg(unix)] { ... } #[cfg(windows)] { Ok(lim) }. So I would remove our config guard completely. It's less code and will handle all cases for us, including all Unixes, not just macOS and Linux.

let _ = rlimit::increase_nofile_limit(u64::MAX);

// std::process::exit doesn't guarantee that all destructors will be run,
// therefore we wrap the main code in another function to ensure that.
// See: https://doc.rust-lang.org/stable/std/process/fn.exit.html
Expand Down
Loading