Add day/night count in sunrise/sunset messages#542
Merged
skizzerz merged 1 commit intolykoss:masterfrom Jul 7, 2025
Merged
Conversation
skizzerz
approved these changes
Jul 7, 2025
Member
skizzerz
left a comment
skizzerz
left a comment
There was a problem hiding this comment.
This doesn't add any counters for day 1 when we start with day (e.g. mudkip), but that doesn't seem important enough to block merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not tested this code change locally, but it *should* work if my Python is right?
(I'll get around to testing it in a few days if you haven't merged it first)
Anyway, look at me submitting a PR as requested (:o