Convert q_value to_s #1266
Open
Convert q_value to_s #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that `q_value` is a string to call method `downcase!` (line 12) and `strip!`. You can pass for example the email parameter = null with Postman: in this scenario you get 500 `NoMethodError (undefined method `downcase!' for nil:NilClass)`
MaicolBen
reviewed
Mar 18, 2019
Collaborator
MaicolBen
left a comment
MaicolBen
left a comment
There was a problem hiding this comment.
Rebase! the specs should pass now. Also, if throws that exception, doesn't it say that something is wrong? This is like hiding the issue
Author
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
q_valueis a string to call methoddowncase!(line 12) andstrip!. You can pass for example the email parameter = null with Postman: in this scenario you get 500NoMethodError (undefined methoddowncase!' for nil:NilClass)`