Fix, Avoid checking resources multi times #1452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
reviewed
Jan 6, 2021
Collaborator
MaicolBen
left a comment
MaicolBen
left a comment
There was a problem hiding this comment.
Thanks for adding the tests
app/controllers/devise_token_auth/concerns/set_user_by_token.rb
Outdated
Show resolved
Hide resolved
| # user auth | ||
| def set_user_by_token(mapping = nil) | ||
| # Avoid checking resources multi times | ||
| return @resource if resource_is_checked?(mapping) |
Collaborator
There was a problem hiding this comment.
should we just use defined?(@resource) instead of this elaborate check?
Author
There was a problem hiding this comment.
If you want instead by defined?(@resource) that is similar return @resource if @resource
And, I'm try set return @resource if defined?(@resource), It works fine when logged in.
But, when not yet logged in it still check resources many times.
leanhthang
force-pushed
the
fix_checking_resource_muti_times
branch
3 times, most recently
from
bd7242f to
0968c7a
Compare
leanhthang
force-pushed
the
fix_checking_resource_muti_times
branch
from
0968c7a to
c176baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use devise_token_auth_group the method 'set_user_by_token' has been call multi times per mapping name. so that, resource has found not reused. That will Increase performance.